The issue has been closed

Contribution proposal 😇 #159

robertrossmann posted onGitHub

Hi!

I would like to contribute to this project as I am using color on a side project of mine. I have the following changes in mind - could you please take a look at them and let me know if you'd be interested in a PR implementing these changes before I actually commit time & effort to them? 🙏

Upgrade color-convert to v2
Drop support for EOL-ed Node.js versions (semver-major ⚠️)
Upgrade xo to 0.24 and update codez to match new rulez 🕵
Add package-lock.json so that every contributor gets to work against the same set of deps 😍
*Implement .ahex() & .hexa(), include tests (similar to #158)

Sure, upgrade away.
Sure, drop EOL - needs to be its own PR
Sure, upgrade XO and fix any resulting issues - needs to be its own PR.
No, please do not add lockfiles. They are conceptually flawed, designed and implemented carelessly, and only cause headache.
Is there a problem with #158? I just haven't gotten around to OSS lately.

Also, please way less emojis...

posted by Qix- over 5 years ago

Fund this Issue

$0.00

Funded

Pull requests

Contribution proposal 😇 #159

Company

Community

Support

Connect