PrismarineJS/prismarine-viewer

Performance improvement #105

rom1504 posted onGitHub

Is there anything we can do so it's faster to render chunks? https://prismarine.js.org/prismarine-viewer/standalone/ Things that can be improved:

  • loading time: it takes about 30s to have the render being finished for the first time
  • new rendering: when moving the view, it takes again about 30s to having the render being complete

This is a limitation in particular when trying to increase the view size to render many things.

What could be done to have this be done faster? (even if lowering the quality, that could be a setting)


the problem is mainly the generation:

  • its filling air chunks
  • its done in the main thread

It shouldn't be too hard to do better: https://github.com/PrismarineJS/prismarine-viewer/blob/master/examples/standalone/index.js#L33

posted by Karang over 4 years ago

Yeah we can run the generator function in other threads in pworld. Hopefully we can do something so it works both with browser and node threads.

On Tue, Dec 29, 2020, 08:06 Karang notifications@github.com wrote:

the problem is mainly the generation:

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PrismarineJS/prismarine-viewer/issues/105#issuecomment-751973816, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR437QPJF2IYH4ITNHTVETSXF5WLANCNFSM4VMZATKQ .

posted by rom1504 over 4 years ago

now good enough by adding setTimeout so the main thread is not blocked

posted by rom1504 over 4 years ago

Fund this Issue

$0.00
Funded

Pull requests