MarchWorks/AniTV

Do you want to work on this issue?

You can request for a bounty in order to promote it!

Notify the user that there is a new update and show the download progress #122

MarchWorks posted onGitHub


Hi, Let me work on this.

posted by Reza-Rajabi over 5 years ago

Hi, I just noticed this repo is using next.js which I don't know much about it. I will work on it in my spare time since I like it, but please feel free to un-assign me or work on it. Thank you.

posted by Reza-Rajabi over 5 years ago

@Reza-Rajabi this doesn't really require any Next.js experience, just add

<div>
// more html
</div>
<style jsx>`{
// your style
}`</style>

after https://github.com/MarchWorks/AniTV/blob/f6724d922a2577825678beeff1626d673c30aa68/renderer/components/layout.js#L9 and use React Hooks to listen to the events

posted by MarchWorks over 5 years ago

Thank you for walking me through this issue. That is helpful. I have the app set up locally, but the buttons don't work in Mac OS. I can not download any video because of that, and I am wondering how could I see the progress bar once I get it done.

posted by Reza-Rajabi over 5 years ago

I think that you will have to send some dummy events with setInterval or something like that to see the progress bar.

For the download button you can see if there is any problem in this function (I am on windows and there is no problem) https://github.com/MarchWorks/AniTV/blob/f6724d922a2577825678beeff1626d673c30aa68/main/functions.js#L111

posted by MarchWorks over 5 years ago

I will try this. Thank you.

posted by Reza-Rajabi over 5 years ago

Unfortunately, auto-updating wouldn't work on macOS because the app needs to be signed which require that I signup for Apple Developer Program which requires money which I don't have

posted by MarchWorks over 5 years ago

@MarchWorks I am not sure if it has anything to do with a Developer account. I think because you are using Electron, and as they said in their Github repo: The Electron framework lets you write cross-platform desktop applications using JavaScript ..., it should work on Mac as well. It is essentially like we are rendering on a Chromium browser. I have never used Electron before, and that's why I am procrastinating on the task that you assigned to me. I love your project, and I would be more than happy to work on that (somewhere after these busy days that I have right now). I am wondering why electron could be a better option rather than releasing this amazing project on a website. I think that way you can also think of the ads. It sounds also being more user-friendly since the user uses it on their browser.

posted by Reza-Rajabi over 5 years ago

Check it here https://samuelmeuli.com/blog/2019-04-07-packaging-and-publishing-an-electron-app/#code-signing I will try to get some money from issueHunte to sign the app

I used electron because it doesn't require a server (for user sign-in and profile data) also subtitles doesn't work with html5 video it requires extracting the subs first (At first this is what I have done in this app but when setting subtitles path ex: E:/someFolder/subs.srt in the track src I get this https://stackoverflow.com/questions/56934579/set-mime-type-or-run-the-native-media-player ) I

posted by MarchWorks over 5 years ago

@MarchWorks For Apple issue, you can signup with a free account and once everything is fine for publishing your app, you can go for the paid version. Still, I think a web app is a better option and a comment with only one positive feedback in StackOverflow is not that much reliable. Here is Mozila's document for the subtitle issue. If you decided to signup with Apple, I suggest starting with a free version and experimenting with it before paying.

posted by Reza-Rajabi over 5 years ago

@Reza-Rajabi Thanks for the info. I will give the web app a try when I find the time

posted by MarchWorks over 5 years ago

@MarchWorks If you decided to do so, I can help with the backend, somewhere in middle of the December up to January.

posted by Reza-Rajabi over 5 years ago

Fund this Issue

$0.00
Funded
Only logged in users can fund an issue

Pull requests