Environment

Self-Hosted (Docker)

System

Docker 20.10.22

Version

2.1.1

Describe the problem

Reproducible directly from the docker image - without nginx or anything else in-between.
docker run --rm -it -p 4322:80 lissy93/dashy

Reproduction steps:

Open localhost:4322.
Switch view > Workspace
Switch view again to either Default or Minimal in the Workspace sidebar.
Switch view > * (any view). 404 page is shown.

NOTE: Hovering on the Switch view in step 4 shows the urls are /home/{home|minimal} /minimal/{home|minimal} /workspace/{home|minimal}. The value in the curly braces depends on whether you press 'Default' or 'Minimal' in Step 3.

Cause of the issue

I started investigating the cause of the bug.

https://github.com/Lissy93/dashy/blob/master/src/components/Settings/ViewSwitcher.vue#L34

    subPagePath() {
      return this.$route.path.split('/').pop() || '';
    },`

Switching view from the Workspace page navigates to a path without a trailing /. I expect this causes the unexpected behaviour from the subPagePath function on the Default/Minimal view switchers.

Rudimentary fix

A quick fix could be adding a trailing / to the switch-view-buttons in components/Workspace/SideBar.vue.

I'm not sure this is an acceptable fix though, because if a user navigated directly to /workspace without the trailing slash the issue might still occur.

Let me know if you require more details.

Additional info

No response

Please tick the boxes

You have explained the issue clearly, and included all relevant info
You are using a supported version of Dashy
You've checked that this issue hasn't already been raised
You've checked the docs and troubleshooting guide
You agree to the code of conduct

dashy/ViewSwitcher.vue at master · Lissy93/dashy

🚀 A self-hostable personal dashboard built for you. Includes status-checking, widgets, themes, icon packs, a UI editor and tons more! - dashy/ViewSwitcher.vue at master · Lissy93/dashy

[BUG] Switching from 'Workspace' view can cause 404 #1064

Company

Community

Support

Connect